linux-kernel - Re: [PATCH net v4 0/4] net: dsa: lantiq: a bunch of fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUGgBj8YZHQnaIsv@makrotopia.org>
Date: Tue, 16 Dec 2025 18:08:06 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: Vladimir Oltean <olteanv@...il.com>
Cc: Hauke Mehrtens <hauke@...ke-m.de>, Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Rasmus Villemoes <ravi@...vas.dk>,
	"Benny (Ying-Tsan) Weng" <yweng@...linear.com>,
	John Crispin <john@...ozen.org>
Subject: Re: [PATCH net v4 0/4] net: dsa: lantiq: a bunch of fixes

On Wed, Dec 10, 2025 at 06:16:33PM +0200, Vladimir Oltean wrote:
> On Tue, Dec 09, 2025 at 01:27:42AM +0000, Daniel Golle wrote:
> > This series is the continuation and result of comments received for a fix
> > for the SGMII restart-an bit not actually being self-clearing, which was
> > reported by by Rasmus Villemoes.
> > 
> > A closer investigation and testing the .remove and the .shutdown paths
> > of the mxl-gsw1xx.c and lantiq_gswip.c drivers has revealed a couple of
> > existing problems, which are also addressed in this series.
> > 
> > Daniel Golle (4):
> >   net: dsa: lantiq_gswip: fix order in .remove operation
> >   net: dsa: mxl-gsw1xx: fix order in .remove operation
> >   net: dsa: mxl-gsw1xx: fix .shutdown driver operation
> >   net: dsa: mxl-gsw1xx: manually clear RANEG bit
> > 
> >  drivers/net/dsa/lantiq/lantiq_gswip.c        |  3 --
> >  drivers/net/dsa/lantiq/lantiq_gswip.h        |  2 --
> >  drivers/net/dsa/lantiq/lantiq_gswip_common.c | 19 +++++-----
> >  drivers/net/dsa/lantiq/mxl-gsw1xx.c          | 38 +++++++++++++++++---
> >  4 files changed, 44 insertions(+), 18 deletions(-)
> > 
> > -- 
> > 2.52.0
> 
> From a DSA API perspective this seems fine.
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> 

In case you are reluctant to accept patch 4/4 ("net: dsa: mxl-gsw1xx:
manually clear RANEG bit") it'd be nice to have at least patch 1, 2 and
3 merged as-is, and I'll resend 4/4 as a single patch being a simple
msleep(10) instead of the delayed_work approach, if that's the reason
for the series not being accepted.