linux-kernel - Re: [PATCH v2] kexec: Replace the goto out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20251216111139.9a96dcbde829bf5d667ff50e@linux-foundation.org>
Date: Tue, 16 Dec 2025 11:11:39 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Qiang Ma <maqianga@...ontech.com>
Cc: bhe@...hat.com, kexec@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kexec: Replace the goto out_unlock with out

On Tue, 16 Dec 2025 15:55:18 +0800 Qiang Ma <maqianga@...ontech.com> wrote:

> The image is initialized to NULL. Then, after calling kimage_alloc_init,
> we can directly goto 'out' because at this time, the kimage_free will
> determine whether image is a NULL pointer.
> 
> This will prepare for the subsequent patch to reset the variable in
> kimage_free.

There doesn't seem to be a benefit to applying this patch unless the
"subsequent patch" is also applied.  So wouldn't a two-patch series be
more appropriate?