linux-kernel - Re: [PATCH RFC v2 2/3] decoder: Add V4L2 stateless H.264 decoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b3f890c-2649-4a29-a620-203d4a72688e@amlogic.com>
Date: Tue, 16 Dec 2025 10:36:17 +0800
From: Zhentao Guo <zhentao.guo@...ogic.com>
To: Nicolas Dufresne <nicolas@...fresne.ca>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>,
 Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>,
 Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH RFC v2 2/3] decoder: Add V4L2 stateless H.264 decoder
 driver


在 2025/12/15 21:58, Nicolas Dufresne 写道:
> Le lundi 15 décembre 2025 à 10:15 +0800, Zhentao Guo a écrit :
>> 在 2025/12/12 21:51, Nicolas Dufresne 写道:
>>> Hi,
>>>
>>> Le vendredi 12 décembre 2025 à 12:11 +0800, Zhentao Guo a écrit :
>>>>> strcpy() would be the preferred helper for this, no need to fill the
>>>>> leading
>>>>> zero liek this, see include/linux/string.h
>>>> Ok, it should be more suitable to use strcpy.
>>> I have to correct myself, I meant to suggest strscpy(dst, src, size).
>>> Passing
>>> the size for safety seems important, and unlike strncpy() it takes care of
>>> the
>>> leading zero.
>> Yes, we use strscpy() for copying all the strings.
> Indeed, I had miss-read, then you simply need to remove the code you added to
> force the last byte to be 0, this is not needed with that function.
Yes, I checked the function strscpy too. It will add the \0 if the 
parameter 'size' is proper. We will remove this step in our code.
> Nicolas
>
>>> Nicolas
>> Thanks
>>
>> Zhentao