linux-kernel - Re: [PATCH] mm/shmem: add mTHP swpout fallback statistics in shmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251216113619.af93c4c37f8e880a14516a2f@linux-foundation.org>
Date: Tue, 16 Dec 2025 11:36:19 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Anshuman Khandual <anshuman.khandual@....com>
Cc: Weilin Tong <tongweilin@...ux.alibaba.com>, Hugh Dickins
 <hughd@...gle.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/shmem: add mTHP swpout fallback statistics in
 shmem_writeout()

On Tue, 16 Dec 2025 12:04:02 +0530 Anshuman Khandual <anshuman.khandual@....com> wrote:

> > --- a/mm/shmem.c
> > +++ b/mm/shmem.c
> > @@ -1593,11 +1593,23 @@ int shmem_writeout(struct folio *folio, struct swap_iocb **plug,
> >  	}
> >  
> >  	if (split) {
> > +		int order;
> > +
> 
> Could this be moved up near the 'nr_pages' declaration instead ?

It could, but I think it's good practice to restrict the scope of
things to "no more than necessary"?