linux-kernel - Re: [PATCH 1/1] linux/bitfield.h: replace __auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aUHKrztKHyxsQM-M@yury>
Date: Tue, 16 Dec 2025 16:10:07 -0500
From: Yury Norov <yury.norov@...il.com>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH 1/1] linux/bitfield.h: replace __auto_type with auto

On Tue, Dec 16, 2025 at 12:52:38PM -0800, H. Peter Anvin wrote:
> Replace "__auto_type" as described in commit:
> 
> 2fb6915fa22d compiler_types.h: add "auto" as a macro for "__auto_type"
> 
> Cc: Yury Norov <yury.norov@...il.com> (maintainer:BITMAP API)
> Cc: Rasmus Villemoes <linux@...musvillemoes.dk> (reviewer:BITMAP API)
> Signed-off-by: H. Peter Anvin (Intel) <hpa@...or.com>

Thanks for the work.

The compiler_types.h is included via build_bug.h -> compiler.h.
It works because there's plenty of BUG_ON()s here, but it's better to
include the compiler_types.h explicitly. Can you please send a v2?

Thanks,
Yury

> ---
>  include/linux/bitfield.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h
> index 126dc5b380af..ecdb8e66dbbe 100644
> --- a/include/linux/bitfield.h
> +++ b/include/linux/bitfield.h
> @@ -243,7 +243,7 @@ __MAKE_OP(64)
>  
>  #define __field_prep(mask, val)						\
>  	({								\
> -		__auto_type __mask = (mask);				\
> +		auto __mask = (mask);					\
>  		typeof(__mask) __val = (val);				\
>  		unsigned int __shift = BITS_PER_TYPE(__mask) <= 32 ?	\
>  				       __ffs(__mask) : __ffs64(__mask);	\
> @@ -252,7 +252,7 @@ __MAKE_OP(64)
>  
>  #define __field_get(mask, reg)						\
>  	({								\
> -		__auto_type __mask = (mask);				\
> +		auto __mask = (mask);					\
>  		typeof(__mask) __reg =  (reg);				\
>  		unsigned int __shift = BITS_PER_TYPE(__mask) <= 32 ?	\
>  				       __ffs(__mask) : __ffs64(__mask);	\
> -- 
> 2.52.0