linux-kernel - Re: [PATCH v2 1/1] kconfig: move XPM icons to separate files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46a5f2d9-b118-4675-8372-40f9b2fc7bbe@infradead.org>
Date: Tue, 16 Dec 2025 14:39:20 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Rostislav Krasny <rostiprodev@...il.com>
Cc: Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nsc@...nel.org>,
 Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] kconfig: move XPM icons to separate files

Hi,

On 12/16/25 12:38 PM, Rostislav Krasny wrote:
> On Tue, 16 Dec 2025 at 09:10, Randy Dunlap <rdunlap@...radead.org> wrote:
>> This worked well for me when I ran 'make gconfig'. However, when I tested
>> 'make xconfig', instead of having icons/symbols for
>>   Back, Open, Save, Single View, Split View, Full View
>> I have words as listed above.
> 
> I've double checked my patch again with the latest master branch of
> Linux and "make xconfig" works properly on my machine.
> Here you can see the screenshot: https://ibb.co/Q2jX9tQ
> 
> I use Fedora 43 with Cinnamon DE. The Qt development package that I
> installed is qt5-qtbase-devel version 5.15.18-1.fc43 plus its
> dependencies.
> What version of Qt do you use? Did "make xconfig" work properly before
> you applied my patch?
> 

Yes, "make xconfig" worked properly before applying this patch.

.qconf.cmd (generated by build) tells me I am using Qt6.
I don't see any build errors/warnings.

qt-core-devel & qt-base-common-devel are v6.10.1-1.2 from
openSUSE Tumbleweed.

> 
> BTW if I install qt6-qtbase-devel (currently version 6.10.1-2.fc43)
> instead of qt5-qtbase-devel it fails on compilation, but this is a
> completely different problem that existed even before my changes. I
> will try to fix it later, it seems like a wrong include path.
> 
> $ make xconfig
>   HOSTCXX scripts/kconfig/qconf.o
> scripts/kconfig/qconf.cc:7:10: fatal error: QAction: No such file or directory
>     7 | #include <QAction>
>       |          ^~~~~~~~~
> compilation terminated.
> make[2]: *** [scripts/Makefile.host:148: scripts/kconfig/qconf.o] Error 1
> make[1]: *** [/home/huligan/develop/linux/Makefile:742: xconfig] Error 2
> make: *** [Makefile:248: __sub-make] Error 2

-- 
~Randy