linux-kernel - Re: [syzbot] [net?] [usb?] memory leak in rtl8150_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACUOwmJSqHu+ZxaKat7uD0X7O483omE56xYkKDU+a=dGs_n-BQ@mail.gmail.com>
Date: Tue, 16 Dec 2025 23:23:27 +0000
From: Raka Gunarto <rakagunarto@...il.com>
To: syzbot <syzbot+8dd915c7cb0490fc8c52@...kaller.appspotmail.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-usb@...r.kernel.org, 
	netdev@...r.kernel.org, pabeni@...hat.com, petkan@...leusys.com, 
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [net?] [usb?] memory leak in rtl8150_set_multicast

async_set_registers() does not free the urb and req on the
usb_submit_urb() call fail path. Fix by freeing both objects.

Reported-by: syzbot+8dd915c7cb0490fc8c52@...kaller.appspotmail.com
Signed-off-by: Raka Gunarto <rakagunarto@...il.com>
---
 drivers/net/usb/rtl8150.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 278e6cb6f4..0f6c700a85 100644
--- a/drivers/net/usb/rtl8150.c
+++ b/drivers/net/usb/rtl8150.c
@@ -211,6 +211,8 @@ static int async_set_registers(rtl8150_t *dev, u16
indx, u16 size, u16 reg)
                if (res == -ENODEV)
                        netif_device_detach(dev->netdev);
                dev_err(&dev->udev->dev, "%s failed with %d\n", __func__, res);
+               usb_free_urb(async_urb);
+               kfree(req);
        }
        return res;
 }
--
2.25.1