linux-kernel - Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Fix interrupt controller node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <668f273b-5214-4f2d-b532-265e4fc6aaef@socionext.com>
Date: Tue, 16 Dec 2025 14:59:03 +0900
From: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To: Rob Herring <robh@...nel.org>
Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 Manivannan Sadhasivam <mani@...nel.org>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Masami Hiramatsu <mhiramat@...nel.org>,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Fix interrupt
 controller node name

On 2025/12/16 11:18, Rob Herring wrote:
> On Mon, Dec 15, 2025 at 7:21 PM Kunihiko Hayashi
> <hayashi.kunihiko@...ionext.com> wrote:
>>
>> Hi Rob,
>>
>> Thank you for pointing out.
>>
>> On 2025/12/16 6:24, Rob Herring (Arm) wrote:
>>> The child node name in use by .dts files and the driver is
>>> "legacy-interrupt-controller", not "interrupt-controller".
>> After your change commit bcd7ec2cd720 were merged, it was a long time
>> before I realized I needed to fix it.
>>
>> "interrupt-controller" is included in the list of Generic Names
>> Recommendation. Would it be better to apply (i.e. restore) this,
>> or fix the PCI driver and .dts?
> 
> It's an ABI. So we are stuck with it or have to support both names in
> the driver forever (and backport the driver change).

I understand.
If allowing "interrupt-controller", should allow both names in the
driver and bindings.

At this time, it's preferable to align the bindings definition to
remove mismatch warnings.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>

Thank you,

---
Best Regards
Kunihiko Hayashi