linux-kernel - Re: [PATCH] LoongArch: Don't define __ARCH_WANT_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <98d93330-844e-493d-8d7e-3455340b78b7@app.fastmail.com>
Date: Tue, 16 Dec 2025 08:21:43 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Xi Ruoyao" <xry111@...111.site>, "Huacai Chen" <chenhuacai@...nel.org>,
 "WANG Xuerui" <kernel@...0n.name>
Cc: "Mingcong Bai" <jeffbai@...c.io>, loongarch@...ts.linux.dev,
 "Jiaxun Yang" <jiaxun.yang@...goat.com>,
 "open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] LoongArch: Don't define __ARCH_WANT_NEW_STAT for LA32

On Mon, Dec 15, 2025, at 04:34, Xi Ruoyao wrote:
> While on LA64 we had added __ARCH_WANT_NEW_STAT back for technological
> aesthetics reason, on LA32 the newstat family suffers Y2038 issue and it
> should not be used at all, as the commit 82b355d161c9 ("y2038: Remove
> newstat family from default syscall set") has already pointed out.
>
> Fixes: 14338e631afd ("LoongArch: Adjust system call for 32BIT/64BIT")
> Signed-off-by: Xi Ruoyao <xry111@...111.site>

The patch looks good to me.

Note that unlike the referenced 82b355d161c9 patch, this is no
longer needed for correctness, since modern kernels generate
the asm/unistd.h from the syscall.tbl based on 
arch/loongarch/kernel/Makefile.syscalls, which leaves out the
references to newstat.

The patch is still useful of course, but only to slightly reduce
the size of the kernel image by eliminating dead code.

     Arnd