linux-kernel - Re: [PATCH] Revert "mtd: spinand: esmt: fix id code for F50D1G41LB"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cy4esvc3.fsf@bootlin.com>
Date: Tue, 16 Dec 2025 09:07:56 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: George Moussalem <george.moussalem@...look.com>
Cc: Ziyang Huang <hzyitc@...look.com>,  quic_mdalam@...cinc.com,
  richard@....at,  vigneshr@...com,  tudor.ambarus@...aro.org,
  mmkurbanov@...utedevices.com,  linux-mtd@...ts.infradead.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "mtd: spinand: esmt: fix id code for F50D1G41LB"

Hi,

>>> This reverts commit dd26402642a0899fde59ea6b0852fad3d799b4cc.
>>>
>>> The issue George met is due to the limit of QPIC, not the issue of the
>>> flash chip.
>>>
>>> QPIC only supports 4 bytes ID. So the fifth byte is always 0.
>>>
>>> If we use spi-gpio, the fifth byte can be read correctly.
>>>
>>> Signed-off-by: Ziyang Huang <hzyitc@...look.com>
>>> ---
>> 
>> So how do we solve that?
>> 
>> Is there anything than can be done on the qpic side?
>
> Hi Alam,
>
> Is the hardware itself limited to reading 4 ID bytes only or is it a
> driver limitation?

FYI I will pick the revert, because indeed the original fix is wrong and
any device with 5 ID bytes would need a similar change (which is not
possible), and let you figure out a quirk for the Qpic driver.

Thanks,
Miquèl