linux-kernel - Re: [PATCH v6] dma-buf: add some tracepoints to debug.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4wbKFf68EW9vF7k6W0PPbMbjnc9s=rKBzqOnhfDwC3F8g@mail.gmail.com>
Date: Tue, 16 Dec 2025 17:05:42 +0800
From: Barry Song <21cnbao@...il.com>
To: Christian König <christian.koenig@....com>
Cc: Xiang Gao <gxxa03070307@...il.com>, sumit.semwal@...aro.org, rostedt@...dmis.org, 
	mhiramat@...nel.org, linux-media@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	mathieu.desnoyers@...icios.com, dhowells@...hat.com, kuba@...nel.org, 
	brauner@...nel.org, akpm@...ux-foundation.org, 
	linux-trace-kernel@...r.kernel.org, gaoxiang17 <gaoxiang17@...omi.com>
Subject: Re: [PATCH v6] dma-buf: add some tracepoints to debug.

On Tue, Dec 16, 2025 at 4:44 PM Christian König
<christian.koenig@....com> wrote:
>
> On 12/16/25 07:39, Xiang Gao wrote:
> > From: gaoxiang17 <gaoxiang17@...omi.com>
> >
> > Since we can only inspect dmabuf by iterating over process FDs or the
> > dmabuf_list, we need to add our own tracepoints to track its status in
> > real time in production.
> >
> > For example:
> >    binder:3016_1-3102    [006] ...1.   255.126521: dma_buf_export: exp_name=qcom,system size=12685312 ino=2738
> >    binder:3016_1-3102    [006] ...1.   255.126528: dma_buf_fd: exp_name=qcom,system size=12685312 ino=2738 fd=8
> >    binder:3016_1-3102    [006] ...1.   255.126642: dma_buf_mmap_internal: exp_name=qcom,system size=28672 ino=2739
> >      kworker/6:1-86      [006] ...1.   255.127194: dma_buf_put: exp_name=qcom,system size=12685312 ino=2738
> >     RenderThread-9293    [006] ...1.   316.618179: dma_buf_get: exp_name=qcom,system size=12771328 ino=2762 fd=176
> >     RenderThread-9293    [006] ...1.   316.618195: dma_buf_dynamic_attach: exp_name=qcom,system size=12771328 ino=2762 attachment:ffffff880a18dd00 is_dynamic=0 dev_name=kgsl-3d0
> >     RenderThread-9293    [006] ...1.   318.878220: dma_buf_detach: exp_name=qcom,system size=12771328 ino=2762 attachment:ffffff880a18dd00 is_dynamic=0 dev_name=kgsl-3d0
> >
> > Signed-off-by: Xiang Gao <gaoxiang17@...omi.com>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>
> Going to push this to drm-misc-next today unless somebody has some last minute objections.

No objection, but I would strongly suggest Xiang include a
diff description next time, after the changelog for each new
version.

I recall clearly commenting on both changelog refinement and
the DMA_BUF_TRACE() macro [1]. It would be better to mention
similar things for each new version next time :-)

[1] https://lore.kernel.org/lkml/CAGsJ_4y0zc_nh2q=w4uR04vtveCf6L7+hgafznHuL8ByWbyNOQ@mail.gmail.com/

Thanks
Barry