linux-kernel - Re: [PATCH] soundwire: qcom: Use guard to avoid mixing cleanup and goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176587679319.348344.13509792002074257048.b4-ty@kernel.org>
Date: Tue, 16 Dec 2025 14:49:53 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Srinivas Kandagatla <srini@...nel.org>, 
 Bard Liao <yung-chuan.liao@...ux.intel.com>, 
 Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>, 
 linux-sound@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
 linux-kernel@...r.kernel.org, 
 Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Subject: Re: [PATCH] soundwire: qcom: Use guard to avoid mixing cleanup and
 goto


On Mon, 01 Dec 2025 11:26:28 +0100, Krzysztof Kozlowski wrote:
> qcom_swrm_stream_alloc_ports() already uses cleanup.h but also has goto.
> Such combination is error-prone and discouraged:
> 
> "... and that the "goto" statement can jump between scopes, the
> expectation is that usage of "goto" and cleanup helpers is never mixed
> in the same function."
> 
> [...]

Applied, thanks!

[1/1] soundwire: qcom: Use guard to avoid mixing cleanup and goto
      commit: 82ab754d102273f4c974a285aa8025bed7521b15

Best regards,
-- 
~Vinod