linux-kernel - Re: [PATCH v3 0/4] gpu: nova-core: fixups for GSP message queue and bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9C5D3184-E3D7-4628-A844-07E4B86696BA@nvidia.com>
Date: Tue, 16 Dec 2025 09:21:56 +0000
From: Joel Fernandes <joelagnelf@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>
CC: Danilo Krummrich <dakr@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Miguel
 Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng
	<boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, Benno Lossin
	<lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, Trevor Gross
	<tmgross@...ch.edu>, John Hubbard <jhubbard@...dia.com>, Alistair Popple
	<apopple@...dia.com>, Timur Tabi <ttabi@...dia.com>, Edwin Peer
	<epeer@...dia.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, Lyude Paul <lyude@...hat.com>, Alexandre
 Courbot <acourbot@...dia.com>
Subject: Re: [PATCH v3 0/4] gpu: nova-core: fixups for GSP message queue and
 bindings



> On Dec 15, 2025, at 9:57 PM, Alexandre Courbot <acourbot@...dia.com> wrote:
> 
> This series contains a few fixups for the recently merged GSP
> command-queue code, by order of importance:
> 
> - Some explicit padding required to safely implement `AsBytes` was
>  missing in the bindings,
> - A bug in the received message length calculation results in the
>  message handler being given more data than it should,
> - `MaybeZeroable` is now derived by the kernel's bindgen, but the Nova
>  bindings have not been updated for that,
> - Some items in the bindings were referred to using the version module
>  directly, instead of the alias we defined to limit the diff when we
>  upgrade firmware versions.
> 
> All of them address "bugs" (with the first two fixing actual correctness
> issues), but since Nova does not do much anyway, they are also not
> absolutely critical. Other series planned for this cycle will depend on
> them, so one way or the other it would be great to see them in
> drm-rust-next.
> 
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
> Changes in v3:
> - Rebase on top of drm-rust-next.
> - Add method to return the payload size of a message. (thanks Alistair!)
> - Link to v2: https://patch.msgid.link/20251123-nova-fixes-v2-0-33d86092cf6a@nvidia.com
> 
> Changes in v2:
> - Add missing "Fixes:" tags.
> - Link to v1: https://lore.kernel.org/r/20251122-nova-fixes-v1-0-a91eafeed7b5@nvidia.com
> 
> ---
> Alexandre Courbot (4):
>      gpu: nova-core: bindings: add missing explicit padding
>      gpu: nova-core: gsp: fix length of received messages
>      gpu: nova-core: bindings: derive `MaybeZeroable`
>      gpu: nova-core: gsp: replace firmware version with "bindings" alias

Reviewed-by: Joel Fernandes <joelagnelf@...dia.com>

thanks,

 - Joel



> 
> drivers/gpu/nova-core/gsp/cmdq.rs                 |  10 ++-
> drivers/gpu/nova-core/gsp/fw.rs                   |  78 ++++++++--------
> drivers/gpu/nova-core/gsp/fw/r570_144.rs          |  11 ++-
> drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs | 105 ++++++++++++----------
> 4 files changed, 110 insertions(+), 94 deletions(-)
> ---
> base-commit: 60c7398bded2e11f0db40a409a241b8be5910ee2
> change-id: 20251121-nova-fixes-dc9b4f17b90e
> 
> Best regards,
> --
> Alexandre Courbot <acourbot@...dia.com>
>