linux-kernel - Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DEZJKZF7787A.3SJOG26WXJ441@kernel.org>
Date: Tue, 16 Dec 2025 10:43:32 +0100
From: "Benno Lossin" <lossin@...nel.org>
To: "Gary Guo" <gary@...yguo.net>, "Christian Schrefl"
 <chrisi.schrefl@...il.com>
Cc: "Miguel Ojeda" <ojeda@...nel.org>, "Boqun Feng" <boqun.feng@...il.com>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "Danilo Krummrich" <dakr@...nel.org>,
 "Fiona Behrens" <me@...enk.dev>, <rust-for-linux@...r.kernel.org>, "Tamir
 Duberstein" <tamird@...il.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2]
 and quote workarounds

On Mon Dec 15, 2025 at 2:01 PM CET, Gary Guo wrote:
> On Thu, 11 Dec 2025 22:50:35 +0100
> Christian Schrefl <chrisi.schrefl@...il.com> wrote:
>
>> Hi Gary,
>> 
>> On 12/11/25 7:56 PM, Gary Guo wrote:
>> > From: Benno Lossin <lossin@...nel.org>
>> > 
>> > The kernel only had the `proc-macro` library available, whereas the
>> > user-space version also used `proc-macro2` and `quote`. Now both are
>> > available to the kernel, making it possible to remove the workarounds.
>> > 
>> > Signed-off-by: Benno Lossin <lossin@...nel.org>
>> > Co-developed-by: Gary Guo <gary@...yguo.net>
>> > Signed-off-by: Gary Guo <gary@...yguo.net>
>> > ---  
>> 
>> Its good to see some workarounds/hacks get removed!
>> 
>> Overall seems fine, but maybe the imports should be changed to the
>> multiline kernel style?
>> 
>> Anyways:
>> 
>> Reviewed-by: Christian Schrefl <chrisi.schrefl@...il.com>
>
> `pin-init` is its own subproject as it's also intended for userspace (or
> other baremetal/embedded users). I'll let Benno to decide if he would like
> to use kernel multiline import for `pin-init`.

I haven't thought about this too much yet. In pin-init, I rarely get
merge conflicts (in fact I don't recall any time when I had one), since
I author most of the patches. Now if the kernel were to change the
rustfmt config, then I'd change it as well.

If I convert it, then I will do so in a separate series as well.

Cheers,
Benno

> The rest of this series convert files to use kernel import style when
> depednencies are changed.
>
> Best,
> Gary