linux-kernel - Re: [PATCH v2] kho: Remove duplicate header file references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+CK2bCyqOKo1oA32TPnL3u+w8VT6MF+pb+Wps57C_P6v2C9ZQ@mail.gmail.com>
Date: Tue, 16 Dec 2025 05:56:27 -0500
From: Pasha Tatashin <pasha.tatashin@...een.com>
To: l00580197 <longwei27@...wei.com>
Cc: Alexander Graf <graf@...zon.com>, Mike Rapoport <rppt@...nel.org>, 
	Pratyush Yadav <pratyush@...nel.org>, kexec@...ts.infradead.org, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, hewenliang4@...wei.com
Subject: Re: [PATCH v2] kho: Remove duplicate header file references

On Tue, Dec 16, 2025 at 1:45 AM l00580197 <longwei27@...wei.com> wrote:
>
> From: Long Wei <longwei27@...wei.com>
>
> Changes in v2:
> - Fixed the malformed commit message header (removed duplicate 'From:' line).
> - Added module prefix 'kho:' to the subject.

Please move changelog into stat section, so it does not appear part of
the commit log.

>
> kexec_handover_internal.h is included twice in kexec_handover.c.
> Remove the redundant first inclusion to eliminate the duplication.
>
> Signed-off-by: Long Wei <longwei27@...wei.com>

With the above:
Reviewed-by: Pasha Tatashin <pasha.tatashin@...een.com>

> ---
>  kernel/liveupdate/kexec_handover.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index 9dc51fab604f..1962b6052840 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -24,7 +24,6 @@
>
>  #include <asm/early_ioremap.h>
>
> -#include "kexec_handover_internal.h"
>  /*
>   * KHO is tightly coupled with mm init and needs access to some of mm
>   * internal APIs.
> --
> 2.43.0