linux-kernel - RE: [PATCH v2 2/4] irqchip: add RZ/{T2H,N2H} Interrupt Controller (ICU) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TYYPR01MB139550D01768B025E402B683D85AAA@TYYPR01MB13955.jpnprd01.prod.outlook.com>
Date: Tue, 16 Dec 2025 12:26:52 +0000
From: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
To: geert <geert@...ux-m68k.org>
CC: Thomas Gleixner <tglx@...utronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	magnus.damm <magnus.damm@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH v2 2/4] irqchip: add RZ/{T2H,N2H} Interrupt Controller
 (ICU) driver

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Tuesday, December 16, 2025 1:48 PM
> To: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; magnus.damm <magnus.damm@...il.com>; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; linux-renesas-soc@...r.kernel.org
> Subject: Re: [PATCH v2 2/4] irqchip: add RZ/{T2H,N2H} Interrupt Controller (ICU) driver
> 
> Hi Cosmin,
> 
> On Mon, 1 Dec 2025 at 12:30, Cosmin Tanislav
> <cosmin-gabriel.tanislav.xa@...esas.com> wrote:
> > The Renesas RZ/T2H (R9A09G077) and Renesas RZ/N2H (R9A09G087) SoCs have
> > an Interrupt Controller (ICU) that supports interrupts from external
> > pins IRQ0 to IRQ15, and SEI, and software-triggered interrupts INTCPU0
> > to INTCPU15.
> >
> > INTCPU0 to INTCPU13, IRQ0 to IRQ13 are non-safety interrupts, while
> > INTCPU14, INTCPU15, IRQ14, IRQ15 and SEI are safety interrupts, and are
> > exposed via a separate register space.
> >
> > Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
> 
> Thanks for your patch, which is now commit 13e7b3305b647cf5
> ("irqchip: Add RZ/{T2H,N2H} Interrupt Controller (ICU) driver")
> in irqchip/irq/drivers.
> 
> > --- a/drivers/soc/renesas/Kconfig
> > +++ b/drivers/soc/renesas/Kconfig
> > @@ -423,6 +423,7 @@ config ARCH_R9A09G057
> >  config ARCH_R9A09G077
> >         bool "ARM64 Platform support for R9A09G077 (RZ/T2H)"
> >         default y if ARCH_RENESAS
> > +       select RENESAS_RZT2H_ICU
> >         help
> >           This enables support for the Renesas RZ/T2H SoC variants.
> >
> 
> This change should have been a separate patch, to be routed through the
> renesas-devel tree.  In addition, you forgot to add the same select to the
> ARCH_R9A09G087 entry below.
> 

My bad, I did not think about that. Is there anything I should be doing now
to fix the situation? Or is it just something to keep in mind for future
patches?

I will submit another patch to add the select to ARCH_R9A09G087.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds