linux-kernel - Re: [PATCH v3 0/3] Add support for exynos5250-manta (Google Nexus 10)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <176589052399.1815190.7793235081822033570.robh@kernel.org>
Date: Tue, 16 Dec 2025 07:11:51 -0600
From: Rob Herring <robh@...nel.org>
To: Lukas Timmermann <linux@...mermann.space>
Cc: Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org, 
 devicetree@...r.kernel.org, phone-devel@...r.kernel.org, 
 Alim Akhtar <alim.akhtar@...sung.com>, Conor Dooley <conor+dt@...nel.org>, 
 Alexandre Marquet <tb@...arquet.fr>, linux-samsung-soc@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v3 0/3] Add support for exynos5250-manta (Google Nexus
 10)


On Mon, 15 Dec 2025 16:05:21 +0100, Lukas Timmermann wrote:
> This patch series adds initial support for the google-manta board, known
> as Google Nexus 10 to users. The device is powered by
> the Exynos 5250 SoC. The bindings for the notification led are already
> in the kernel mailing list, got recently applied and can be found here:
> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
> 
> The first two patches add the necessary device tree files and
> bindings, while the last patch makes a small modification to
> allow CPU1 to boot, as it requires a call to it's underlying firmware.
> 
> This first iteration only provides basic support to get the board
> up and running and usable via UART and with WiFi support. We will upstream additional
> features in future patches. All patches have been tested on real hardware.
> 
> Changes in v3:
>  - Added a better patch description for firmware patch. (@krzk)
>  - Reorganized nodes in DT. (@krzk)
>  - Fixed memory node to use separate entries. (@krzk)
>  - Renamed pwrseq node. (@krzk)
>  - Fixed firmware checking for old dt compatible string. (@pavel)
>  - Link to v2: https://lore.kernel.org/all/20251125-google-manta-v2-0-0f097cfff39c@timmermann.space/
> Changes in v2:
>  - Renamed to google-manta (@krzk)
>  - Link to v1: https://lore.kernel.org/all/20251120144018.961604-2-linux@timmermann.space/
> 
> Signed-off-by: Lukas Timmermann <linux@...mermann.space>
> ---
> Alexandre Marquet (3):
>       dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)
>       ARM: dts: exynos: Add Google Manta (Nexus 10)
>       ARM: samsung: exynos5250: Allow CPU1 to boot
> 
>  .../bindings/arm/samsung/samsung-boards.yaml       |   1 +
>  arch/arm/boot/dts/samsung/Makefile                 |   1 +
>  arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 511 +++++++++++++++++++++
>  arch/arm/mach-exynos/firmware.c                    |   4 +-
>  4 files changed, 515 insertions(+), 2 deletions(-)
> ---
> base-commit: d5f0e9098499869354aacb5b080f602f0399d396
> change-id: 20251215-lat3st-staging-d9c926d8a75f
> 
> Best regards,
> --
> Lukas Timmermann <linux@...mermann.space>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: base-commit d5f0e9098499869354aacb5b080f602f0399d396 not known, ignoring
 Base: attempting to guess base-commit...
 Base: tags/next-20251215 (exact match)
 Base: tags/next-20251215 (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/samsung/' for 20251215-lat3st-staging-v3-0-2e4914b64dd8@...mermann.space:

arch/arm/boot/dts/samsung/exynos5250-manta.dtb: /soc/i2c@...70000/led-controller@42: failed to match any schema with compatible: ['ams,as3668']
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@...e0000 (samsung,s3c6410-rtc): clock-names: ['rtc'] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@...e0000 (samsung,s3c6410-rtc): clocks: [[2, 337]] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml