linux-kernel - Re: [PATCH] mm: memcg: fix unit conversion for K() macro in OOM log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <ACCDA933-E222-4890-A29E-2C77CD4DE35A@linux.dev>
Date: Wed, 17 Dec 2025 10:35:03 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
 Johannes Weiner <hannes@...xchg.org>,
 Michal Hocko <mhocko@...nel.org>,
 Roman Gushchin <roman.gushchin@...ux.dev>,
 Vlastimil Babka <vbabka@...e.cz>,
 Meta kernel team <kernel-team@...a.com>,
 cgroups@...r.kernel.org,
 linux-mm@...ck.org,
 linux-kernel@...r.kernel.org,
 Chris Mason <clm@...com>
Subject: Re: [PATCH] mm: memcg: fix unit conversion for K() macro in OOM log



> On Dec 17, 2025, at 05:20, Shakeel Butt <shakeel.butt@...ux.dev> wrote:
> 
> The commit bc8e51c05ad5 ("mm: memcg: dump memcg protection info on oom
> or alloc failures") added functionality to dump memcg protections on OOM
> or allocation failures. It uses K() macro to dump the information and
> passes bytes to the macro. However the macro take number of pages
> instead of bytes. It is defined as:
> 
> #define K(x) ((x) << (PAGE_SHIFT-10))
> 
> Let's fix this.
> 
> Signed-off-by: Shakeel Butt <shakeel.butt@...ux.dev>
> Reported-by: Chris Mason <clm@...com>
> Fixes: bc8e51c05ad5 ("mm: memcg: dump memcg protection info on oom or alloc failures")

Reviewed-by: Muchun Song <muchun.song@...ux.dev>

Thanks.