linux-kernel - Re: [PATCH] staging: rtl8723bs: fix block comment coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025121724-unshaved-irritable-4c34@gregkh>
Date: Wed, 17 Dec 2025 14:06:50 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Adrish Bora <adrishbora@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	straube.linux@...il.com
Subject: Re: [PATCH] staging: rtl8723bs: fix block comment coding style

On Sun, Dec 14, 2025 at 02:26:08PM +0000, Adrish Bora wrote:
> Fix the block comment style in os_intfs.c to match the kernel coding style.
> The comment was previously lacking the required asterisks on subsequent lines.
> 
> Signed-off-by: Adrish Bora <adrishbora@...il.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index 6ca6dc548805..ca841cc61076 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -934,14 +934,16 @@ static int netdev_close(struct net_device *pnetdev)
>  	padapter->net_closed = true;
>  	padapter->netif_up = false;
>  
> -/*if (!padapter->hw_init_completed)
> -	{
> -
> -		padapter->bDriverStopped = true;
> -
> -		rtw_dev_unload(padapter);
> -	}
> -	else*/
> +/*
> + * if (!padapter->hw_init_completed)
> + *	{
> + *
> + *		padapter->bDriverStopped = true;
> + *
> + *		rtw_dev_unload(padapter);
> + *	}
> + *	else
> + */

If this code has been commented out for a long time, please just delete
it, no need to make it "pretty" with a different style of comment block.

thanks,

greg k-h