linux-kernel - Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string "qcom,qcc2072-bt" to yaml file.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d180711b-7957-4252-b34b-81312705555b@molgen.mpg.de>
Date: Wed, 17 Dec 2025 15:14:40 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Vivek Kumar Sahu <vivesahu@....qualcomm.com>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Balakrishna Godavarthi <quic_bgodavar@...cinc.com>,
 Rocky Liao <quic_rjliao@...cinc.com>, quic_mohamull@...cinc.com,
 quic_hbandi@...cinc.com, linux-bluetooth@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 1/2] DT: add bindings for QCC2072 Add DT compatible string
 "qcom,qcc2072-bt" to yaml file.

Dear Vivek,

Thank you for your patch. The formatting is off, and the summary/title 
(subject) has two statements – look yourself in the archive [1]. Also 
the prefix seems wrong.

Am 17.12.25 um 12:28 schrieb Vivek Kumar Sahu:
> Signed-off-by: Vivek Kumar Sahu <vivesahu@....qualcomm.com>

Please elaborate by giving more context, why it is compatible, and I’d 
like to see how you tested this.

> ---
>   .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml    | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> index 6353a336f382..197248d6f7b8 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> @@ -28,6 +28,7 @@ properties:
>         - qcom,wcn6750-bt
>         - qcom,wcn6855-bt
>         - qcom,wcn7850-bt
> +      - qcom,qcc2072-bt

Lacking more lines, I am not certain, but I maybe this should be sorted.

>   
>     enable-gpios:
>       maxItems: 1

Kind regards,

Paul

[1]: 
https://lore.kernel.org/all/20251217112850.520572-1-vivesahu@qti.qualcomm.com/