lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMuHMdXNX1Yq65sEF1Urgrws4CNXMfpex7sh7LbEp4=oKcq=YA@mail.gmail.com>
Date: Wed, 17 Dec 2025 15:33:42 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Joel Granados <joel.granados@...nel.org>
Cc: Petr Mladek <pmladek@...e.com>, Chris Down <chris@...isdown.name>, linux-kernel@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	Steven Rostedt <rostedt@...dmis.org>, John Ogness <john.ogness@...utronix.de>, 
	Tony Lindgren <tony.lindgren@...ux.intel.com>, kernel-team@...com
Subject: Re: [PATCH v8 20/21] printk: Deprecate the kernel.printk sysctl interface

Hi Joel,

On Wed, 17 Dec 2025 at 12:47, Joel Granados <joel.granados@...nel.org> wrote:
> On Mon, Dec 15, 2025 at 05:06:40PM +0100, Petr Mladek wrote:
> > On Mon 2025-12-15 10:52:28, Joel Granados wrote:
> > > On Fri, Dec 12, 2025 at 04:51:46PM +0100, Petr Mladek wrote:
> > > > > +               pr_warn_once("printk: The kernel.printk sysctl is deprecated. Consider using kernel.console_loglevel or kernel.default_message_loglevel instead.\n");
> > > Line seems very long. cut it in two?
> >
> > OK, what about the following?
> >
> >       pr_warn_once("printk: The kernel.printk sysctl is deprecated and will be removed in 2036.\n");
> >       pr_warn_once("printk: Use kernel.console_loglevel or kernel.default_message_loglevel instead.\n");
> I meant it more as a long line in the code. Not a long line in the
> log. Like this:
>
>   pr_warn_once("printk: The kernel.printk sysctl is deprecated. Instead, use "
>                "kernel.console_loglevel or kernel.default_message_loglevel.\n");
>
> Its still long, but more manageable.

Please do not split long messages, as it makes it harder to find them
in the source tree.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ