linux-kernel - [PATCH] ASoC: Intel: sof_es8336: Fix headphone GPIO inversion logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251217155139.185006-1-tgaraev653@gmail.com>
Date: Wed, 17 Dec 2025 18:51:39 +0300
From: Tagir Garaev <tgaraev653@...il.com>
To: cezary.rojewski@...el.com,
	pierre-louis.bossart@...ux.dev,
	broonie@...nel.org
Cc: liam.r.girdwood@...ux.intel.com,
	peter.ujfalusi@...ux.intel.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Tagir Garaev <tgaraev653@...il.com>
Subject: [PATCH] ASoC: Intel: sof_es8336: Fix headphone GPIO inversion logic

The headphone GPIO should be set to the inverse of speaker_en.
When speakers are enabled, headphones should be disabled and vice versa.

Currently both GPIOs are set to the same value (speaker_en), causing
audio to play through both speakers and headphones simultaneously
when headphones are plugged in.

Tested on Huawei Matebook (BOD-WXX9) with ES8336 codec.

Fixes: commit_sha ("ASoC: Intel: sof_es8336: add headphone GPIO
support")
Signed-off-by: Tagir Garaev <tgaraev653@...il.com>
---
 sound/soc/intel/boards/sof_es8336.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/sof_es8336.c b/sound/soc/intel/boards/sof_es8336.c
index 774fff58d..fce50fd9f 100644
--- a/sound/soc/intel/boards/sof_es8336.c
+++ b/sound/soc/intel/boards/sof_es8336.c
@@ -120,7 +120,7 @@ static void pcm_pop_work_events(struct work_struct *work)
 	gpiod_set_value_cansleep(priv->gpio_speakers, priv->speaker_en);
 
 	if (quirk & SOF_ES8336_HEADPHONE_GPIO)
-		gpiod_set_value_cansleep(priv->gpio_headphone, priv->speaker_en);
+		gpiod_set_value_cansleep(priv->gpio_headphone, !priv->speaker_en);
 
 }
 
-- 
2.52.0