linux-kernel - Re: [PATCH 1/2] rust: pci: document Bar's endianness conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DF0MPUGED5JR.1JBLR4H5IF1TG@kernel.org>
Date: Wed, 17 Dec 2025 17:23:36 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Marko Turk" <mt@...koturk.info>
Cc: <bhelgaas@...gle.com>, <kwilczynski@...nel.org>,
 <miguel.ojeda.sandonis@...il.com>, <dirk.behme@...bosch.com>,
 <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH 1/2] rust: pci: document Bar's endianness conversion

On Wed Dec 10, 2025 at 12:25 PM CET, Marko Turk wrote:
> Document that the Bar's MMIO backend always assumes little-endian
> devices and that its operations automatically convert to CPU endianness.
>
> Signed-off-by: Marko Turk <mt@...koturk.info>
> Link: https://lore.kernel.org/lkml/DE7F6RR1NAKW.3DJYO44O73941@kernel.org/
> ---
>  rust/kernel/pci/io.rs | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/pci/io.rs b/rust/kernel/pci/io.rs
> index 0d55c3139b6f..bfa9df9e9bb9 100644
> --- a/rust/kernel/pci/io.rs
> +++ b/rust/kernel/pci/io.rs
> @@ -18,9 +18,12 @@
>  
>  /// A PCI BAR to perform I/O-Operations on.
>  ///
> +/// I/O backend assumes that the device is little-endian and will automatically
> +/// convert from little-endian to CPU endianness.
> +///
>  /// # Invariants
>  ///
> -/// `Bar` always holds an `IoRaw` inststance that holds a valid pointer to the start of the I/O
> +/// `Bar` always holds an `IoRaw` instance that holds a valid pointer to the start of the I/O

Can you please send this typo fix as a separate patch?

No need to resend this one though, I can change it up on my end.

- Danilo