linux-kernel - Re: [PATCH 3/7] dm-verity: remove unnecessary condition for verity_fec_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251217174651.GC2944334@google.com>
Date: Wed, 17 Dec 2025 17:46:51 +0000
From: Sami Tolvanen <samitolvanen@...gle.com>
To: Eric Biggers <ebiggers@...nel.org>
Cc: dm-devel@...ts.linux.dev, Alasdair Kergon <agk@...hat.com>,
	Mike Snitzer <snitzer@...nel.org>,
	Mikulas Patocka <mpatocka@...hat.com>,
	Benjamin Marzinski <bmarzins@...hat.com>,
	Eran Messeri <eranm@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] dm-verity: remove unnecessary condition for
 verity_fec_finish_io()

On Tue, Dec 16, 2025 at 03:06:10PM -0800, Eric Biggers wrote:
> Make verity_finish_io() call verity_fec_finish_io() unconditionally,
> instead of skipping it when 'in_bh' is true.
> 
> Although FEC can't have been done when 'in_bh' is true,
> verity_fec_finish_io() is a no-op when FEC wasn't done.  An earlier
> change also made verity_fec_finish_io() very lightweight when FEC wasn't
> done.  So it should just be called unconditionally.
> 
> Signed-off-by: Eric Biggers <ebiggers@...nel.org>

Reviewed-by: Sami Tolvanen <samitolvanen@...gle.com>

Sami