linux-kernel - Re: [PATCH v8 20/21] printk: Deprecate the kernel.printk sysctl interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3wdkt3v4i3fj3etwt5u6m326p3jkdziquqgiao5rwvsoccnc4@xm4dqtjfudee>
Date: Wed, 17 Dec 2025 21:23:20 +0100
From: Joel Granados <joel.granados@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, 
	Petr Mladek <pmladek@...e.com>, Chris Down <chris@...isdown.name>, linux-kernel@...r.kernel.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Sergey Senozhatsky <senozhatsky@...omium.org>, 
	John Ogness <john.ogness@...utronix.de>, Tony Lindgren <tony.lindgren@...ux.intel.com>, 
	kernel-team@...com
Subject: Re: [PATCH v8 20/21] printk: Deprecate the kernel.printk sysctl
 interface

On Wed, Dec 17, 2025 at 11:04:43AM -0500, Steven Rostedt wrote:
> On Wed, 17 Dec 2025 15:33:42 +0100
> Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> 
> > > > OK, what about the following?
> > > >
> > > >       pr_warn_once("printk: The kernel.printk sysctl is deprecated and will be removed in 2036.\n");
> > > >       pr_warn_once("printk: Use kernel.console_loglevel or kernel.default_message_loglevel instead.\n");  
> > > I meant it more as a long line in the code. Not a long line in the
> > > log. Like this:
> > >
> > >   pr_warn_once("printk: The kernel.printk sysctl is deprecated. Instead, use "
> > >                "kernel.console_loglevel or kernel.default_message_loglevel.\n");
> > >
> > > Its still long, but more manageable.  
> > 
> > Please do not split long messages, as it makes it harder to find them
> > in the source tree.
> 
> Right. Linus has stated that strings should not be split just because they
> go over the column limit.

Oops, my bad. In that case, just leave it in one line.

   pr_warn_once("printk: The kernel.printk sysctl is deprecated. Instead, use kernel.console_loglevel or kernel.default_message_loglevel.\n");

I would even try to make it shorter. Do you actually need the "kernel"
string? If it still make sense without explicitly stating the "kernel"
dir, then I would shorten it to this:

   pr_warn_once("printk sysctl is deprecated. Use console_loglevel or default_message_loglevel insetad.\n");

Best
-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)