linux-kernel - Re: [PATCH 3/3] rust: cpumask: rename methods of Cpumask for clarity and consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aUMUA_JWalyGQdAx@google.com>
Date: Wed, 17 Dec 2025 20:35:15 +0000
From: Alice Ryhl <aliceryhl@...gle.com>
To: yilin <1479826151@...com>
Cc: Viresh Kumar <viresh.kumar@...aro.org>, Miguel Ojeda <ojeda@...nel.org>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] rust: cpumask: rename methods of Cpumask for clarity
 and consistency

On Thu, Dec 11, 2025 at 11:17:59PM +0800, yilin wrote:
> Rename `as_ref` and `as_mut_ref` to `from_raw` and `from_raw_mut` to
> align with the established naming convention for constructing types
> from raw pointers in the kernel's Rust codebase.
> 
> Signed-off-by: yilin <1479826151@...com>

You need to use a real identity such as your real name here. Please see:
https://docs.kernel.org/process/submitting-patches.html#reviewer-s-statement-of-oversight

You should probably also split this series up, as the patches are for
unrelated subsystem.s

The change itself looks good:
Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>

>  rust/kernel/cpumask.rs | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/rust/kernel/cpumask.rs b/rust/kernel/cpumask.rs
> index c1d17826a..44bb36636 100644
> --- a/rust/kernel/cpumask.rs
> +++ b/rust/kernel/cpumask.rs
> @@ -39,7 +39,7 @@
>  /// fn set_clear_cpu(ptr: *mut bindings::cpumask, set_cpu: CpuId, clear_cpu: CpuId) {
>  ///     // SAFETY: The `ptr` is valid for writing and remains valid for the lifetime of the
>  ///     // returned reference.
> -///     let mask = unsafe { Cpumask::as_mut_ref(ptr) };
> +///     let mask = unsafe { Cpumask::from_raw_mut(ptr) };
>  ///
>  ///     mask.set(set_cpu);
>  ///     mask.clear(clear_cpu);
> @@ -49,13 +49,13 @@
>  pub struct Cpumask(Opaque<bindings::cpumask>);
>  
>  impl Cpumask {
> -    /// Creates a mutable reference to an existing `struct cpumask` pointer.
> +    /// Creates a mutable reference from an existing `struct cpumask` pointer.
>      ///
>      /// # Safety
>      ///
>      /// The caller must ensure that `ptr` is valid for writing and remains valid for the lifetime
>      /// of the returned reference.
> -    pub unsafe fn as_mut_ref<'a>(ptr: *mut bindings::cpumask) -> &'a mut Self {
> +    pub unsafe fn from_raw_mut<'a>(ptr: *mut bindings::cpumask) -> &'a mut Self {
>          // SAFETY: Guaranteed by the safety requirements of the function.
>          //
>          // INVARIANT: The caller ensures that `ptr` is valid for writing and remains valid for the
> @@ -63,13 +63,13 @@ pub unsafe fn as_mut_ref<'a>(ptr: *mut bindings::cpumask) -> &'a mut Self {
>          unsafe { &mut *ptr.cast() }
>      }
>  
> -    /// Creates a reference to an existing `struct cpumask` pointer.
> +    /// Creates a reference from an existing `struct cpumask` pointer.
>      ///
>      /// # Safety
>      ///
>      /// The caller must ensure that `ptr` is valid for reading and remains valid for the lifetime
>      /// of the returned reference.
> -    pub unsafe fn as_ref<'a>(ptr: *const bindings::cpumask) -> &'a Self {
> +    pub unsafe fn from_raw<'a>(ptr: *const bindings::cpumask) -> &'a Self {
>          // SAFETY: Guaranteed by the safety requirements of the function.
>          //
>          // INVARIANT: The caller ensures that `ptr` is valid for reading and remains valid for the
> -- 
> 2.34.1
>