[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqKdrN5UpUWQVQXpJjbTy1gN9_FhhwOoX6zVpG+zZVAptA@mail.gmail.com>
Date: Wed, 17 Dec 2025 14:41:14 -0600
From: Rob Herring <robh@...nel.org>
To: Michal Simek <michal.simek@....com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: xilinx: Drop "label" property on dlg,slg7xl45106
On Wed, Dec 17, 2025 at 6:39 AM Michal Simek <michal.simek@....com> wrote:
> On 12/16/25 18:59, Rob Herring (Arm) wrote:
> > The "label" property is not documented for the dlg,slg7xl45106. Nor is
> > it common to use for GPIO controllers. So drop it.
> >
>
> Correct it is not documented but it is at least used in Linux also by
> drivers/gpio/gpio-mmio.c:810: err = device_property_read_string(dev, "label",
> &label);
>
> which is also not documented in DT binding.
It really should be for all GPIO providers or none of them. IMO, it
should be none of them as we already have "gpio-line-names" which is
essentially per line labels. I can't see why anyone should care about
a label for the controller.
> I don't have a problem with it because I can't see it used anywhere.
>
> But there are other devices where label is the part of binding. And IMHO this
> should be more generic property.
"label" is the generic property. Not sure what you are suggesting here.
Rob
Powered by blists - more mailing lists