linux-kernel - Re: [PATCH RFC] crypto/hkdf: Skip tests with keys too short in FIPS mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251217041307.GB3424@sol>
Date: Tue, 16 Dec 2025 20:13:07 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Li Tian <litian@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S . Miller" <davem@...emloft.net>,
	Vitaly Kuznetsov <vkuznets@...hat.com>,
	Simo Sorce <ssorce@...hat.com>
Subject: Re: [PATCH RFC] crypto/hkdf: Skip tests with keys too short in FIPS
 mode

On Wed, Dec 17, 2025 at 08:08:48AM +0800, Li Tian wrote:
> On Wed, Dec 10, 2025 at 6:54 AM Eric Biggers <ebiggers@...nel.org> wrote:
> > What problem are you trying to solve?
> 
> Eric, as you've said "keylen < 14 check in the new version in
> crypto/sha256.c." was forgotten.
> IMHO, it deserves recovery in terms of FIPS. And by the time the check
> is restored, the hkdf_test
> cases failure will likely surface again. Hence the skipping in this proposal.
> 
> Li Tian

Sure, but there's no reason to consider this patch unless the incorrect
and problematic keylen check is added back in.

- Eric