linux-kernel - Re: [PATCH] RDMA/irdma: avoid invalid read in irdma_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251217180351.GB211693@nvidia.com>
Date: Wed, 17 Dec 2025 14:03:51 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Michal Schmidt <mschmidt@...hat.com>
Cc: Krzysztof Czurylo <krzysztof.czurylo@...el.com>,
	Tatyana Nikolova <tatyana.e.nikolova@...el.com>,
	Leon Romanovsky <leon@...nel.org>,
	Shiraz Saleem <shiraz.saleem@...el.com>,
	Mustafa Ismail <mustafa.ismail@...el.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/irdma: avoid invalid read in irdma_net_event

On Thu, Nov 27, 2025 at 03:31:50PM +0100, Michal Schmidt wrote:
> irdma_net_event() should not dereference anything from "neigh" (alias
> "ptr") until it has checked that the event is NETEVENT_NEIGH_UPDATE.
> Other events come with different structures pointed to by "ptr" and they
> may be smaller than struct neighbour.
> 
> Move the read of neigh->dev under the NETEVENT_NEIGH_UPDATE case.
> 
> The bug is mostly harmless, but it triggers KASAN on debug kernels:
> 
> Fixes: 915cc7ac0f8e ("RDMA/irdma: Add miscellaneous utility definitions")
> Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> ---
>  drivers/infiniband/hw/irdma/utils.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to for-rc, thanks

Jason