linux-kernel - Re: [PATCH bpf-next v9 07/10] btf: Verify BTF Sorting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0244da50ae77dfab30a8e49514761f5bba147768.camel@gmail.com>
Date: Tue, 16 Dec 2025 16:41:20 -0800
From: Eduard Zingerman <eddyz87@...il.com>
To: Donglin Peng <dolinux.peng@...il.com>, ast@...nel.org, 
	andrii.nakryiko@...il.com
Cc: zhangxiaoqin@...omi.com, ihor.solodrai@...ux.dev, 
	linux-kernel@...r.kernel.org, bpf@...r.kernel.org, pengdonglin
	 <pengdonglin@...omi.com>, Alan Maguire <alan.maguire@...cle.com>
Subject: Re: [PATCH bpf-next v9 07/10] btf: Verify BTF Sorting

On Tue, 2025-12-09 at 11:21 +0800, Donglin Peng wrote:

[...]

> > @@ -5889,6 +5943,8 @@ static struct btf *btf_parse(const union bpf_attr *attr, bpfptr_t uattr, u32 uat
> >         if (err)
> >                 goto errout;
> > 
> > +       btf_check_sorted(btf);
> 
> I think there is no need to check sorting here, because the BTF in this
> code path is generated by the compiler. We only need to cover the cases
> of vmlinux and kernel module BTF.

Idk, we can teach compiler to sort BTF types one day.
Having this call shouldn't incur too much overhead, right?

> > +
> >         struct_meta_tab = btf_parse_struct_metas(&env->log, btf);
> >         if (IS_ERR(struct_meta_tab)) {
> >                 err = PTR_ERR(struct_meta_tab);

[...]