linux-kernel - Re: [PATCH] tty/n_hdlc: Fix struct n

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPqLRf18v3eQaKsaaf+wB6k5+v65=BkQG2dtS=Bcyee=isOatw@mail.gmail.com>
Date: Wed, 17 Dec 2025 08:35:56 +0100
From: Bartłomiej Kubik <kubik.bartlomiej@...il.com>
To: gregkh@...uxfoundation.org
Cc: jirislaby@...nel.org, linux-serial@...r.kernel.org, 
	linux-kernel@...r.kernel.org, david.hunter.linux@...il.com, 
	skhan@...uxfoundation.org, khalid@...nel.org, 
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] tty/n_hdlc: Fix struct n_hdlc kernel-doc warnings

Hi,

I submitted this patch about two weeks ago but haven't received any
feedback yet.
I wanted to check if there are any concerns with the patch or if any
changes are needed.

Please let me know if you need any additional information.

Best regards
Bartłomiej Kubik

On Tue, 2 Dec 2025 at 07:38, Bartlomiej Kubik
<kubik.bartlomiej@...il.com> wrote:
>
> Add missing descriptions for write_work and tty_for_write_work
> members in struct n_hdlc.
>
> This fixes the following warnings:
> drivers/tty/n_hdlc.c: warning: Function parameter or member
>                                'write_work' not described in 'n_hdlc'
> drivers/tty/n_hdlc.c: warning: Function parameter or member
>                                'tty_for_write_work' not described in 'n_hdlc'
>
> Signed-off-by: Bartlomiej Kubik <kubik.bartlomiej@...il.com>
> ---
>  drivers/tty/n_hdlc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c
> index 4a4dc58b866a..ac0605ac9d46 100644
> --- a/drivers/tty/n_hdlc.c
> +++ b/drivers/tty/n_hdlc.c
> @@ -127,6 +127,8 @@ struct n_hdlc_buf_list {
>   * @rx_buf_list: list of received frame buffers
>   * @tx_free_buf_list: list unused transmit frame buffers
>   * @rx_free_buf_list: list unused received frame buffers
> + * @write_work: work struct for deferred frame transmission
> + * @tty_for_write_work: pointer to tty instance used by the @write_work
>   */
>  struct n_hdlc {
>         bool                    tbusy;
> --
> 2.39.5
>