linux-kernel - Re: [PATCH 02/14] mm: Describe @flags parameter in memalloc_flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e76e25ef-f112-4689-9753-34709613b9c2@kernel.org>
Date: Wed, 17 Dec 2025 01:09:18 +0100
From: "David Hildenbrand (Red Hat)" <david@...nel.org>
To: Bagas Sanjaya <bagasdotme@...il.com>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Linux AMDGPU <amd-gfx@...ts.freedesktop.org>,
 Linux DRI Development <dri-devel@...ts.freedesktop.org>,
 Linux Filesystems Development <linux-fsdevel@...r.kernel.org>,
 Linux Media <linux-media@...r.kernel.org>, linaro-mm-sig@...ts.linaro.org,
 kasan-dev@...glegroups.com,
 Linux Virtualization <virtualization@...ts.linux.dev>,
 Linux Memory Management List <linux-mm@...ck.org>,
 Linux Network Bridge <bridge@...ts.linux.dev>,
 Linux Networking <netdev@...r.kernel.org>
Cc: Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>,
 Rodrigo Siqueira <siqueira@...lia.com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Matthew Brost <matthew.brost@...el.com>, Danilo Krummrich <dakr@...nel.org>,
 Philipp Stanner <phasta@...nel.org>, Alexander Viro
 <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>,
 Jan Kara <jack@...e.cz>, Sumit Semwal <sumit.semwal@...aro.org>,
 Alexander Potapenko <glider@...gle.com>, Marco Elver <elver@...gle.com>,
 Dmitry Vyukov <dvyukov@...gle.com>, "Michael S. Tsirkin" <mst@...hat.com>,
 Jason Wang <jasowang@...hat.com>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
 Eugenio Pérez <eperezma@...hat.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Uladzislau Rezki <urezki@...il.com>,
 Nikolay Aleksandrov <razor@...ckwall.org>, Ido Schimmel <idosch@...dia.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Taimur Hassan <Syed.Hassan@....com>,
 Wayne Lin <Wayne.Lin@....com>, Alex Hung <alex.hung@....com>,
 Aurabindo Pillai <aurabindo.pillai@....com>,
 Dillon Varone <Dillon.Varone@....com>, George Shen <george.shen@....com>,
 Aric Cyr <aric.cyr@....com>, Cruise Hung <Cruise.Hung@....com>,
 Mario Limonciello <mario.limonciello@....com>,
 Sunil Khatri <sunil.khatri@....com>,
 Dominik Kaszewski <dominik.kaszewski@....com>,
 Peter Zijlstra <peterz@...radead.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Max Kellermann <max.kellermann@...os.com>,
 "Nysal Jan K.A." <nysal@...ux.ibm.com>, Ryan Roberts <ryan.roberts@....com>,
 Alexey Skidanov <alexey.skidanov@...el.com>, Vlastimil Babka
 <vbabka@...e.cz>, Kent Overstreet <kent.overstreet@...ux.dev>,
 Vitaly Wool <vitaly.wool@...sulko.se>, Harry Yoo <harry.yoo@...cle.com>,
 Mateusz Guzik <mjguzik@...il.com>, NeilBrown <neil@...wn.name>,
 Amir Goldstein <amir73il@...il.com>, Jeff Layton <jlayton@...nel.org>,
 Ivan Lipski <ivan.lipski@....com>, Tao Zhou <tao.zhou1@....com>,
 YiPeng Chai <YiPeng.Chai@....com>, Hawking Zhang <Hawking.Zhang@....com>,
 Lyude Paul <lyude@...hat.com>, Daniel Almeida
 <daniel.almeida@...labora.com>, Luben Tuikov <luben.tuikov@....com>,
 Matthew Auld <matthew.auld@...el.com>,
 Roopa Prabhu <roopa@...ulusnetworks.com>, Mao Zhu <zhumao001@...suo.com>,
 Shaomin Deng <dengshaomin@...rlc.com>, Charles Han <hanchunchao@...pur.com>,
 Jilin Yuan <yuanjilin@...rlc.com>,
 Swaraj Gaikwad <swarajgaikwad1925@...il.com>,
 George Anthony Vernon <contact@...rnon.com>
Subject: Re: [PATCH 02/14] mm: Describe @flags parameter in
 memalloc_flags_save()

On 12/15/25 12:38, Bagas Sanjaya wrote:
> Sphinx reports kernel-doc warning:
> 
> WARNING: ./include/linux/sched/mm.h:332 function parameter 'flags' not described in 'memalloc_flags_save'
> 
> Describe @flags to fix it.
> 
> Fixes: 3f6d5e6a468d02 ("mm: introduce memalloc_flags_{save,restore}")
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>
> ---
>   include/linux/sched/mm.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h
> index 0e1d73955fa511..95d0040df58413 100644
> --- a/include/linux/sched/mm.h
> +++ b/include/linux/sched/mm.h
> @@ -325,6 +325,7 @@ static inline void might_alloc(gfp_t gfp_mask)
>   
>   /**
>    * memalloc_flags_save - Add a PF_* flag to current->flags, save old value
> + * @flags: Flags to add.
>    *
>    * This allows PF_* flags to be conveniently added, irrespective of current
>    * value, and then the old version restored with memalloc_flags_restore().

Acked-by: David Hildenbrand (Red Hat) <david@...nel.org>

-- 
Cheers

David