linux-kernel - [PATCH] fbcon: Add check for return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20251217091036.249549-1-a.vatoropin@crpt.ru>
Date: Wed, 17 Dec 2025 09:11:05 +0000
From: Ваторопин Андрей
	<a.vatoropin@...t.ru>
To: Simona Vetter <simona@...ll.ch>
CC: Ваторопин Андрей
	<a.vatoropin@...t.ru>, Helge Deller <deller@....de>, Thomas Zimmermann
	<tzimmermann@...e.de>, Ville Syrjälä
	<ville.syrjala@...ux.intel.com>, Sam Ravnborg <sam@...nborg.org>, Shixiong Ou
	<oushixiong@...inos.cn>, Kees Cook <kees@...nel.org>, Zsolt Kajtar
	<soci@....rulez.org>, Andrew Morton <akpm@...ux-foundation.org>, "Antonino A.
 Daplas" <adaplas@...il.com>, "linux-fbdev@...r.kernel.org"
	<linux-fbdev@...r.kernel.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "lvc-project@...uxtesting.org"
	<lvc-project@...uxtesting.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: [PATCH] fbcon: Add check for return value

From: Andrey Vatoropin <a.vatoropin@...t.ru>

If fbcon_open() fails when called from con2fb_acquire_newinfo() then
info->fbcon_par pointer remains NULL which is later dereferenced.

Add check for return value of the function con2fb_acquire_newinfo() to
avoid it.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: d1baa4ffa677 ("fbcon: set_con2fb_map fixes")
Cc: stable@...r.kernel.org
Signed-off-by: Andrey Vatoropin <a.vatoropin@...t.ru>
---
 drivers/video/fbdev/core/fbcon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index e7e07eb2142e..7453377f3433 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1047,7 +1047,8 @@ static void fbcon_init(struct vc_data *vc, bool init)
 		return;
 
 	if (!info->fbcon_par)
-		con2fb_acquire_newinfo(vc, info, vc->vc_num);
+		if (con2fb_acquire_newinfo(vc, info, vc->vc_num))
+			return;
 
 	/* If we are not the first console on this
 	   fb, copy the font from that console */
-- 
2.43.0