linux-kernel - Re: [PATCH 1/3] gpio: realtek-otto: use kernel_ulong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MdhXqO_b6DU8v6rkuNwsEVO-zY7UP0sXO=2P3tM+uFzHA@mail.gmail.com>
Date: Wed, 17 Dec 2025 10:34:26 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-gpio@...r.kernel.org, Linus Walleij <linusw@...nel.org>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] gpio: realtek-otto: use kernel_ulong_t

On Wed, Dec 17, 2025 at 7:32 AM Rosen Penev <rosenp@...il.com> wrote:
>
> Fixes compilation on 64-bit platforms as pointers needed a larger type.
>
> Signed-off-by: Rosen Penev <rosenp@...il.com>
> ---
>  drivers/gpio/gpio-realtek-otto.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-realtek-otto.c b/drivers/gpio/gpio-realtek-otto.c
> index de527f4fc6c2..efcddbe01308 100644
> --- a/drivers/gpio/gpio-realtek-otto.c
> +++ b/drivers/gpio/gpio-realtek-otto.c
> @@ -372,7 +372,7 @@ static int realtek_gpio_probe(struct platform_device *pdev)
>         if (!ctrl)
>                 return -ENOMEM;
>
> -       dev_flags = (unsigned int) device_get_match_data(dev);
> +       dev_flags = (unsigned int)(kernel_ulong_t)device_get_match_data(dev);
>
>         ngpios = REALTEK_GPIO_MAX;
>         device_property_read_u32(dev, "ngpios", &ngpios);
> --
> 2.52.0
>

Just make dev_flags an unsigned long and cast
device_get_match_data(dev) to uintptr_t.

Bart