linux-kernel - Re: [PATCH 4/4] selftests/mm: fix exit code in pagemap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67e61dd6-2a44-42f5-980e-e9196d672540@sirena.org.uk>
Date: Wed, 17 Dec 2025 10:08:42 +0000
From: Mark Brown <broonie@...nel.org>
To: Kevin Brodsky <kevin.brodsky@....com>
Cc: linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Hildenbrand <david@...nel.org>,
	Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
	Ryan Roberts <ryan.roberts@....com>, Shuah Khan <shuah@...nel.org>,
	Usama Anjum <Usama.Anjum@....com>
Subject: Re: [PATCH 4/4] selftests/mm: fix exit code in pagemap_ioctl

On Tue, Dec 16, 2025 at 02:26:33PM +0000, Kevin Brodsky wrote:
> pagemap_ioctl always reports success, whether the tests succeeded or
> not. Call ksft_finished() to report the right status.

> While at it also fix the exit code in unexpected situations:

This is a general sign that you should have muliple patches...

> - Report FAIL if we failed to open /proc/self/pagemap (returning
>   -EINVAL from main() is meaningless)

If you do a new version it's probably worth noting that this is a
non-optional feature introduced a long time ago so the open should never
fail.

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)