[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <053c515b-ac8f-4bb9-b9b0-c02c0e8f180f@infradead.org>
Date: Tue, 16 Dec 2025 18:02:14 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: Rostislav Krasny <rostiprodev@...il.com>
Cc: Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nsc@...nel.org>,
Masahiro Yamada <masahiroy@...nel.org>, linux-kbuild@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] kconfig: move XPM icons to separate files
On 12/16/25 5:54 PM, Rostislav Krasny wrote:
> Replace deprecated gdk_pixbuf_new_from_xpm_data() with gdk_pixbuf_new_from_file()
> and update both GTK and QT frontends to load XPM icons from separate files
> in scripts/kconfig/icons/ instead of from the code.
>
> xpm_menu_inv and xpm_void were removed and not converted into xpm files
> because they are not used since 64285dc5c41fc7a031695c2c286a2bfef9eaf2c6
>
> This eliminates the GTK deprecation warnings at compile time, improves
> memory usage and code organization.
>
> Signed-off-by: Rostislav Krasny <rostiprodev@...il.com>
OK, this v3 patch works for me with both gconfig and xconfig.
Thanks.
Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>
> ---
> scripts/kconfig/Makefile | 4 +-
> scripts/kconfig/gconf.c | 35 ++-
> scripts/kconfig/icons/back.xpm | 29 +++
> scripts/kconfig/icons/choice_no.xpm | 18 ++
> scripts/kconfig/icons/choice_yes.xpm | 18 ++
> scripts/kconfig/icons/load.xpm | 31 +++
> scripts/kconfig/icons/menu.xpm | 18 ++
> scripts/kconfig/icons/menuback.xpm | 18 ++
> scripts/kconfig/icons/save.xpm | 31 +++
> scripts/kconfig/icons/single_view.xpm | 28 +++
> scripts/kconfig/icons/split_view.xpm | 28 +++
> scripts/kconfig/icons/symbol_mod.xpm | 18 ++
> scripts/kconfig/icons/symbol_no.xpm | 18 ++
> scripts/kconfig/icons/symbol_yes.xpm | 18 ++
> scripts/kconfig/icons/tree_view.xpm | 28 +++
> scripts/kconfig/images.c | 328 --------------------------
> scripts/kconfig/images.h | 33 ---
> scripts/kconfig/qconf.cc | 29 ++-
> 18 files changed, 345 insertions(+), 385 deletions(-)
> create mode 100644 scripts/kconfig/icons/back.xpm
> create mode 100644 scripts/kconfig/icons/choice_no.xpm
> create mode 100644 scripts/kconfig/icons/choice_yes.xpm
> create mode 100644 scripts/kconfig/icons/load.xpm
> create mode 100644 scripts/kconfig/icons/menu.xpm
> create mode 100644 scripts/kconfig/icons/menuback.xpm
> create mode 100644 scripts/kconfig/icons/save.xpm
> create mode 100644 scripts/kconfig/icons/single_view.xpm
> create mode 100644 scripts/kconfig/icons/split_view.xpm
> create mode 100644 scripts/kconfig/icons/symbol_mod.xpm
> create mode 100644 scripts/kconfig/icons/symbol_no.xpm
> create mode 100644 scripts/kconfig/icons/symbol_yes.xpm
> create mode 100644 scripts/kconfig/icons/tree_view.xpm
> delete mode 100644 scripts/kconfig/images.c
> delete mode 100644 scripts/kconfig/images.h
--
~Randy
Powered by blists - more mailing lists