linux-kernel - Re: [RFC PATCH v2] fs: touch up symlink clean up in lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251217113827.GW1712166@ZenIV>
Date: Wed, 17 Dec 2025 11:38:27 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: brauner@...nel.org, jack@...e.cz, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, clm@...a.com
Subject: Re: [RFC PATCH v2] fs: touch up symlink clean up in lookup

On Wed, Dec 17, 2025 at 12:23:45PM +0100, Mateusz Guzik wrote:
> Provide links_cleanup_rcu() and links_cleanup_ref() for rcu- and ref-
> walks respectively.
> 
> The somewhat misleading drop_links() gets renamed to links_issue_delayed_calls(),
> which spells out what it is actually doing.

IMO the replacement name is worse; it doesn't say anything about
the purpose of those "issued delayed calls", for starters.

> There are no changes in behavior, this however should be less
> error-prone going forward.

I disagree, but at the moment (6:30am here, and I'd been up since 11am yesterday ;-/)
I don't trust my ability to produce coherent detailed reply.  I'll reply in detail
once I get some sleep...