linux-kernel - Re: [PATCH] ASoC: tlv320aic32x4: Fix missing error check for devm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7358b2d-d9c9-4092-8ab4-5b9ba6f29341@sirena.org.uk>
Date: Wed, 17 Dec 2025 11:58:44 +0000
From: Mark Brown <broonie@...nel.org>
To: Haotian Zhang <vulab@...as.ac.cn>
Cc: Shenghao Ding <shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>,
	Baojun Xu <baojun.xu@...com>, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: tlv320aic32x4: Fix missing error check for
 devm_clk_register()

On Wed, Dec 17, 2025 at 10:50:51AM +0800, Haotian Zhang wrote:

>  	for (i = 0; i < ARRAY_SIZE(aic32x4_clkdesc_array); ++i)
> -		aic32x4_register_clk(dev, &aic32x4_clkdesc_array[i]);
> +		clk = aic32x4_register_clk(dev, &aic32x4_clkdesc_array[i]);
> +		if (IS_ERR(clk))
> +			return PTR_ERR(clk);

If an error does happen this will leak all the previously registered
clocks.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)