linux-kernel - Re: [PATCH v3 01/22] drm/bridge: add of_drm_find_and_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DF1ESI44XZ00.I0EK3DH2Y7LR@bootlin.com>
Date: Thu, 18 Dec 2025 15:23:35 +0100
From: "Luca Ceresoli" <luca.ceresoli@...tlin.com>
To: "Maxime Ripard" <mripard@...nel.org>
Cc: <dri-devel@...ts.freedesktop.org>, <imx@...ts.linux.dev>,
 <linux-amlogic@...ts.infradead.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-doc@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, "Alexey Brodkin" <abrodkin@...opsys.com>,
 "Andrzej Hajda" <andrzej.hajda@...el.com>, "David Airlie"
 <airlied@...il.com>, "Fabio Estevam" <festevam@...il.com>, "Hui Pu"
 <Hui.Pu@...ealthcare.com>, "Jernej Skrabec" <jernej.skrabec@...il.com>,
 "Jerome Brunet" <jbrunet@...libre.com>, "Jonas Karlman" <jonas@...boo.se>,
 "Jonathan Corbet" <corbet@....net>, "Kevin Hilman" <khilman@...libre.com>,
 "Laurent Pinchart" <Laurent.pinchart@...asonboard.com>, "Liu Ying"
 <victor.liu@....com>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Martin Blumenstingl"
 <martin.blumenstingl@...glemail.com>, "Neil Armstrong"
 <neil.armstrong@...aro.org>, "Pengutronix Kernel Team"
 <kernel@...gutronix.de>, "Phong LE" <ple@...libre.com>, "Robert Foss"
 <rfoss@...nel.org>, "Sascha Hauer" <s.hauer@...gutronix.de>, "Shawn Guo"
 <shawnguo@...nel.org>, "Simona Vetter" <simona@...ll.ch>, "Thomas
 Petazzoni" <thomas.petazzoni@...tlin.com>, "Thomas Zimmermann"
 <tzimmermann@...e.de>
Subject: Re: [PATCH v3 01/22] drm/bridge: add of_drm_find_and_get_bridge()

Hi Maxime,

On Thu Dec 18, 2025 at 1:50 PM CET, Maxime Ripard wrote:
> Hi,
>
> On Wed, Dec 17, 2025 at 03:31:01PM +0100, Luca Ceresoli wrote:
>> On Wed Dec 17, 2025 at 11:15 AM CET, Maxime Ripard wrote:
>> > On Tue, 16 Dec 2025 18:58:34 +0100, Luca Ceresoli wrote:
>> >> of_drm_find_bridge() does not increment the refcount for the returned
>> >> bridge, but that is required now. However converting it and all its users
>> >> is not realistically doable at once given the large amount of (direct and
>> >> indirect) callers and the complexity of some.
>> >>
>> >>
>> >> [ ... ]
>> >
>> > Reviewed-by: Maxime Ripard <mripard@...nel.org>
>>
>> Thank you for the prompt review!
>>
>> All patches are reviewed now except patch 18 which has no reply. I'm just
>> pointing out in case it's something you missed.
>
> Yes, I couldn't really understand the implications of that one, so I'll
> leave the review to the maintainers.

OK, make sense, it's not a trivial patch to review.

Patches 1-4,6 contain the core changes and they are all reviewed, which is
the most important part to me. Everything else is just "a bunch of driver
conversions" and they can flow in over time. I'm also sending more such
driver conversions in separate series, for other drivers.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com