linux-kernel - Re: [PATCH] RDMA/bnxt_re: Replace cpu_to_be64 + le64_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251218151851.GA400630@unreal>
Date: Thu, 18 Dec 2025 17:18:51 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Selvin Xavier <selvin.xavier@...adcom.com>,
	Kalesh AP <kalesh-anakkur.purayil@...adcom.com>,
	Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] RDMA/bnxt_re: Replace cpu_to_be64 + le64_to_cpu with
 swab64

On Wed, Dec 10, 2025 at 02:15:29PM +0100, Thorsten Blum wrote:
> Replace cpu_to_be64(le64_to_cpu()) with swab64() to simplify
> bnxt_re_assign_pma_port_ext_counters().  No functional changes.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>  drivers/infiniband/hw/bnxt_re/hw_counters.c | 19 ++++++-------------
>  1 file changed, 6 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/bnxt_re/hw_counters.c b/drivers/infiniband/hw/bnxt_re/hw_counters.c
> index 651cf9d0e0c7..bb1137ad84c0 100644
> --- a/drivers/infiniband/hw/bnxt_re/hw_counters.c
> +++ b/drivers/infiniband/hw/bnxt_re/hw_counters.c
> @@ -290,19 +290,12 @@ int bnxt_re_assign_pma_port_ext_counters(struct bnxt_re_dev *rdev, struct ib_mad
>  	pma_cnt_ext = (struct ib_pma_portcounters_ext *)(out_mad->data + 40);
>  	if ((bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx) && rdev->is_virtfn) ||
>  	    !bnxt_qplib_is_chip_gen_p5(rdev->chip_ctx)) {
> -		pma_cnt_ext->port_xmit_data =
> -			cpu_to_be64(le64_to_cpu(hw_stats->tx_ucast_bytes) / 4);

> +		pma_cnt_ext->port_xmit_data = swab64(hw_stats->tx_ucast_bytes / 4);

Why do you think that the above two lines are equal?
hw_stats->tx_ucast_bytes is __le64 value and le64_to_cpu(hw_stats->tx_ucast_bytes) / 4) is not equal to
hw_stats->tx_ucast_bytes / 4.

Thanks