linux-kernel - Re: [PATCH v3 1/2] dt-bindings: PCI: qcom,pcie-ep-sa8255p: Document firmware managed PCIe endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39f420d6-f9f5-45b4-9e33-16a283564215@kernel.org>
Date: Thu, 18 Dec 2025 16:41:01 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mrinmay Sarkar <mrinmay.sarkar@....qualcomm.com>,
 "Rob Herring (Arm)" <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Rama Krishna <quic_ramkri@...cinc.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, Ayiluri Naga Rashmi <quic_nayiluri@...cinc.com>,
 Conor Dooley <conor+dt@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Manivannan Sadhasivam <mani@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>, linux-kernel@...r.kernel.org,
 quic_shazhuss@...cinc.com,
 Manivannan Sadhasivam <manivannan.sadhasivam@....qualcomm.com>,
 linux-pci@...r.kernel.org, konrad.dybcio@....qualcomm.com,
 Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
 Nitesh Gupta <quic_nitegupt@...cinc.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 quic_vbadigan@...cinc.com
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: qcom,pcie-ep-sa8255p: Document
 firmware managed PCIe endpoint

On 18/12/2025 10:44, Mrinmay Sarkar wrote:
> On Wed, Dec 17, 2025 at 5:02 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>>
>>
>> On Wed, 17 Dec 2025 15:42:45 +0530, Mrinmay Sarkar wrote:
>>> Document the required configuration to enable the PCIe Endpoint controller
>>> on SA8255p which is managed by firmware using power-domain based handling.
>>>
>>> Signed-off-by: Mrinmay Sarkar <mrinmay.sarkar@....qualcomm.com>
>>> ---
>>>  .../bindings/pci/qcom,pcie-ep-sa8255p.yaml         | 110 +++++++++++++++++++++
>>>  1 file changed, 110 insertions(+)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/qcom,pcie-ep-sa8255p.example.dtb: pcie-ep@...0000 (qcom,pcie-ep-sa8255p): compatible: 'oneOf' conditional failed, one must be fixed:
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,sar[0-9]+[a-z]?-.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,(glymur|milos)-.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,gcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,mmcc-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,pcie-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,rpm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm)[0-9]+.*$'
>>         'qcom,pcie-ep-sa8255p' does not match '^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+.*$'
>>         'qcom,pcie-ep-sa8255p' is not one of ['qcom,dsi-ctrl-6g-qcm2290', 'qcom,gpucc-sdm630', 'qcom,gpucc-sdm660', 'qcom,lcc-apq8064', 'qcom,lcc-ipq8064', 'qcom,lcc-mdm9615', 'qcom,lcc-msm8960', 'qcom,lpass-cpu-apq8016', 'qcom,usb-ss-ipq4019-phy', 'qcom,usb-hs-ipq4019-phy', 'qcom,vqmmc-ipq4019-regulator']
>>         'qcom,pcie-ep-sa8255p' is not one of ['qcom,ipq806x-gmac', 'qcom,ipq806x-nand', 'qcom,ipq806x-sata-phy', 'qcom,ipq806x-usb-phy-ss', 'qcom,ipq806x-usb-phy-hs']
>>         from schema $id: http://devicetree.org/schemas/arm/qcom-soc.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.kernel.org/project/devicetree/patch/20251217-firmware_managed_ep-v3-1-ff871ba688fb@oss.qualcomm.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
> 
> 
> Hi Krzysztof,
> 
> As per our discussion in V1, you mentioned dt binding filename must
> match the compatible
> and I should rewrite compatible to match filename.
> 
> V1 discussion: https://lore.kernel.org/all/CAMyL0qO2FPBe7N6Q=hW-ymeiGDhABsU+VCj25jzcoQRhBoWbDA@mail.gmail.com/

You should respond to that discussion. When you question reviewers
comment, you respond to that comment, not somewhere else. That way I
have entire context and I already told you that when you were poking me
on private channels.

Bindings do not allow old (or incorrect) naming scheme for EP and I
already see EP compatibles were named with the proper new style, so
let's switch to that one - qcom,sa8255p-pcie-ep



Best regards,
Krzysztof