linux-kernel - Re: [PATCH] RDMA/cxgb4: fix dst refcount leak in pass_accept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251218160523.GD400630@unreal>
Date: Thu, 18 Dec 2025 18:05:23 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Wentao Liang <vulab@...as.ac.cn>
Cc: bharat@...lsio.com, jgg@...pe.ca, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] RDMA/cxgb4: fix dst refcount leak in pass_accept_req()
 error path

On Mon, Dec 15, 2025 at 03:33:56PM +0000, Wentao Liang wrote:
> Add missing dst_release() when alloc_ep_skb_list() fails to prevent
> reference count leak of the dst obtained from route lookup.

I'm not convinced this path is correct. I also don't see a call to  
"kfree(child_ep);" in that case.

Thanks

> 
> Fixes: 4a740838bf44 ("RDMA/iw_cxgb4: Low resource fixes for connection manager")
> Cc: stable@...r.kernel.org
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index b3b45c49077d..3490b8920cf0 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -2665,6 +2665,7 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb)
>  	}
>  	goto out;
>  fail:
> +	dst_release(dst);
>  	c4iw_put_ep(&child_ep->com);
>  reject:
>  	reject_cr(dev, hwtid, skb);
> -- 
> 2.34.1
>