linux-kernel - Re: [PATCH] ksmbd: Fix to handle removal of rfc1002 header from smb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4fbcbad-459a-412c-918c-0279ec890353@linux.dev>
Date: Fri, 19 Dec 2025 00:49:19 +0800
From: ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev>
To: David Howells <dhowells@...hat.com>, Namjae Jeon <linkinjeon@...nel.org>
Cc: Steve French <sfrench@...ba.org>,
 Sergey Senozhatsky <senozhatsky@...omium.org>, Tom Talpey <tom@...pey.com>,
 Paulo Alcantara <pc@...guebit.org>, Shyam Prasad N <sprasad@...rosoft.com>,
 linux-cifs@...r.kernel.org, netfs@...ts.linux.dev,
 linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ksmbd: Fix to handle removal of rfc1002 header from
 smb_hdr

Hi Namjae,

It seems David is correct, the `LENGTH` field is described in RFC1002 
section 4.3.1: https://www.rfc-editor.org/rfc/rfc1002#section-4.3.1

The LENGTH field is the number of bytes following the LENGTH
field.  In other words, LENGTH is the combined size of the
TRAILER field(s).

Thanks,
ChenXiaoSong.

On 12/19/25 12:01 AM, David Howells wrote:
> ChenXiaoSong <chenxiaosong.chenxiaosong@...ux.dev> wrote:
> 
> Actually, should SMB2_MIN_SUPPORTED_HEADER_SIZE include the +4 at all?
> pdu_size is the length stored in the RFC1002 header, which does not include
> itself.
> 
> David
>