linux-kernel - Re: [PATCH 12/12] mm/damon/core: add trace point for damos stat per apply interval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251218030411.42049-1-sj@kernel.org>
Date: Wed, 17 Dec 2025 19:04:11 -0800
From: SeongJae Park <sj@...nel.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: SeongJae Park <sj@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	damon@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH 12/12] mm/damon/core: add trace point for damos stat per apply interval

On Wed, 17 Dec 2025 18:29:15 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Wed, 17 Dec 2025 15:52:18 -0800 SeongJae Park <sj@...nel.org> wrote:
> 
> > On Wed, 17 Dec 2025 17:48:51 -0500 Steven Rostedt <rostedt@...dmis.org> wrote:
> > 
> > > On Tue, 16 Dec 2025 00:01:25 -0800
> > > SeongJae Park <sj@...nel.org> wrote:
> > > 
> > > > +	TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu "
> > > > +			"nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu "
> > > > +			"qt_exceeds=%lu nr_snapshots=%lu",
> > > 
> > > Nit, but it's been stated that strings should not be broken up because of
> > > the column limit.
> 
> screw the rules
> 
> > --- a/include/trace/events/damon.h
> > +++ b/include/trace/events/damon.h
> > @@ -40,9 +40,7 @@ TRACE_EVENT(damos_stat_after_apply_interval,
> >  		__entry->nr_snapshots = stat->nr_snapshots;
> >  	),
> >  
> > -	TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu "
> > -			"nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu "
> > -			"qt_exceeds=%lu nr_snapshots=%lu",
> > +	TP_printk("ctx_idx=%u scheme_idx=%u nr_tried=%lu sz_tried=%lu nr_applied=%lu sz_tried=%lu sz_ops_filter_passed=%lu qt_exceeds=%lu nr_snapshots=%lu",
> >  			__entry->context_idx, __entry->scheme_idx,
> >  			__entry->nr_tried, __entry->sz_tried,
> >  			__entry->nr_applied, __entry->sz_applied,
> 
> because that's just crazy.  Let's use some judgment here!

I'm fine with either direction.  So I understand you want to just keep the
original patch without this fixup, and therefore no action is needed from my
side?  Let me know if I'm getting anything wrong.


Thanks,
SJ

[...]