[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <14660520-f338-4719-9cd6-4d6c7d667106@samsung.com>
Date: Thu, 18 Dec 2025 18:14:14 +0100
From: Marek Szyprowski <m.szyprowski@...sung.com>
To: Guenter Roeck <linux@...ck-us.net>, Leon Romanovsky <leon@...nel.org>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>, Helge Deller
<deller@....de>, Jason Gunthorpe <jgg@...pe.ca>
Cc: linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: Set valid bit in high byte of 64‑bit physical address
On 18.12.2025 17:22, Guenter Roeck wrote:
> On 12/18/25 04:08, Leon Romanovsky wrote:
>> From: Leon Romanovsky <leonro@...dia.com>
>>
>> On 32‑bit systems, phys_addr_t is defined as u32. However, parisc
>> expects physical addresses to be 64‑bit values so it can store a
>> validity bit in the upper byte.
>>
>> Resolve this mismatch by casting the physical address to unsigned
>> long, ensuring it is treated as a 64‑bit value where required. This
>> fixes the failure to start block device drivers on the C3700
>> platform, as reported by Guenter.
>>
>> Also remove the now‑obsolete macro.
>>
>> QEMU command line to reproduce the issue (with Debian SID as rootfs):
>> qemu-system-hppa -machine C3700 \
>> -kernel arch/parisc/boot/bzImage \
>> -append "console=ttyS0 \
>> root=/dev/sda rw rootwait panic=-1" \
>> -nographic \
>> -device lsi53c895a \
>> -drive file=rootfs-hppa.img,if=none,format=raw,id=hd0 \
>> -device scsi-hd,drive=hd0
>>
>> Fixes: 96ddf2ef58ec ("parisc: Convert DMA map_page to map_phys
>> interface")
>> Reported-by: Guenter Roeck <linux@...ck-us.net>
>> Closes:
>> https://lore.kernel.org/all/b184f1bf-96dc-4546-8512-9cba5ecb58f7@roeck-us.net/
>> Signed-off-by: Leon Romanovsky <leonro@...dia.com>
>
> Tested-by: Guenter Roeck <linux@...ck-us.net>
Thanks for the initial report and a quick fix. I'm sorry that this issue
slipped through the review and tests in linux-next. I've applied it to
dma-mapping-fixes branch.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Powered by blists - more mailing lists