linux-kernel - Re: [PATCH v10 1/8] treewide: provide a generic clear_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <873457ziw2.fsf@oracle.com>
Date: Thu, 18 Dec 2025 11:31:41 -0800
From: Ankur Arora <ankur.a.arora@...cle.com>
To: "David Hildenbrand (Red Hat)" <david@...nel.org>
Cc: Ankur Arora <ankur.a.arora@...cle.com>, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, x86@...nel.org, akpm@...ux-foundation.org,
        bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com,
        mingo@...hat.com, mjguzik@...il.com, luto@...nel.org,
        peterz@...radead.org, tglx@...utronix.de, willy@...radead.org,
        raghavendra.kt@....com, chleroy@...nel.org, ioworker0@...il.com,
        boris.ostrovsky@...cle.com, konrad.wilk@...cle.com
Subject: Re: [PATCH v10 1/8] treewide: provide a generic clear_user_page()
 variant


David Hildenbrand (Red Hat) <david@...nel.org> writes:

> On 12/15/25 21:49, Ankur Arora wrote:
>> From: David Hildenbrand <david@...hat.com>
>> Let's drop all variants that effectively map to clear_page() and
>> provide it in a generic variant instead.
>> We'll use the macro clear_user_page to indicate whether an architecture
>> provides it's own variant. Maybe at some point these should be CONFIG_
>> options.
>
> Can we drop the second sentence?

Ack.

>> Also, clear_user_page() is only called from the generic variant of
>> clear_user_highpage(), so define it only if the architecture does
>> not provide a clear_user_highpage(). And, for simplicity define it
>> in linux/highmem.h.
>> Note that for parisc, clear_page() and clear_user_page() map to
>> clear_page_asm(), so we can just get rid of the custom clear_user_page()
>> implementation. There is a clear_user_page_asm() function on parisc,
>> that seems to be unused. Not sure what's up with that.
>> Signed-off-by: David Hildenbrand <david@...hat.com>
>
> You should likely now add
>
> Co-developed-by: Ankur Arora <ankur.a.arora@...cle.com>
>
> above your SB :)

:).

>> Signed-off-by: Ankur Arora <ankur.a.arora@...cle.com>
>
> Skimmed over it and nothing jumped at me.

Great!

--
ankur