linux-kernel - Re: [PATCH] lib/crypto: use rol32 in md5.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251218193312.GE21380@sol>
Date: Thu, 18 Dec 2025 11:33:12 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: "Rusydi H. Makarim" <rusydi.makarim@...ptograf.id>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>,
	Ard Biesheuvel <ardb@...nel.org>, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitor@...r.kernel.org
Subject: Re: [PATCH] lib/crypto: use rol32 in md5.c

On Sun, Dec 14, 2025 at 06:15:12PM +0700, Rusydi H. Makarim wrote:
> use rol32 in MD5STEP
> 
> ---
> this patch replaces the bitwise left rotation in lib/crypto/md5.c
> with rol32
> 
> Signed-off-by: Rusydi H. Makarim <rusydi.makarim@...ptograf.id>
> ---
>  lib/crypto/md5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

I cleaned up your commit message as follows:

commit 325c29e7d11caaf3b4f04f2c8f7d6bc4861cce5a
Author: Rusydi H. Makarim <rusydi.makarim@...ptograf.id>
Date:   Sun Dec 14 18:15:12 2025 +0700

    lib/crypto: md5: Use rol32() instead of open-coding it

    For the bitwise left rotation in MD5STEP, use rol32() from
    <linux/bitops.h> instead of open-coding it.

    Signed-off-by: Rusydi H. Makarim <rusydi.makarim@...ptograf.id>
    Link: https://lore.kernel.org/r/20251214-rol32_in_md5-v1-1-20f5f11a92b2@kriptograf.id
    Signed-off-by: Eric Biggers <ebiggers@...nel.org>

For future reference: please don't include a scissors line in the middle
of your commit message.  Everything below it gets cut off.

- Eric