linux-kernel - Re: [PATCH v1] phy: fsl-imx8mq-usb: Fix PCS_TX_SWING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aURX2-jM0FZbLNrc@Lord-Beerus.station>
Date: Thu, 18 Dec 2025 20:36:59 +0100
From: Stefano Radaelli <stefano.radaelli21@...il.com>
To: Fabio Estevam <festevam@...il.com>
Cc: vkoul@...nel.org, neil.armstrong@...aro.org, shawnguo@...nel.org,
	s.hauer@...gutronix.de, kernel@...gutronix.de,
	j.zink@...gutronix.de, linux-kernel@...r.kernel.org,
	xu.yang_2@....com, jun.li@....com, Frank.Li@....com,
	haibo.chen@....com, linux-phy@...ts.infradead.org,
	imx@...ts.linux.dev, Stefano Radaelli <stefano.r@...iscite.com>,
	Pierluigi Passaro <pierluigi.p@...iscite.com>
Subject: Re: [PATCH v1] phy: fsl-imx8mq-usb: Fix PCS_TX_SWING_FULL register
 configuration

Hi Fabio,
> 
> The change looks good to me, but the Subject is a bit misleading.
> 
> It gives the impression that PCS_TX_SWING_FULL is a register.
> 
> What about:
> 
> phy: fsl-imx8mq-usb: Clear the PCS_TX_SWING_FULL field before using it

Thank you for the review! You're absolutely right, the subject was
misleading. I'll send a v2 with the improved subject line you suggested.

Best regards,
Stefano