linux-kernel - Re: [PATCH 0/4] nova-core Improve pin initializer code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <FB4E7596-3C84-4D65-81F2-57036F725C0C@nvidia.com>
Date: Thu, 18 Dec 2025 21:06:22 +0000
From: Joel Fernandes <joelagnelf@...dia.com>
To: Danilo Krummrich <dakr@...nel.org>
CC: Alexandre Courbot <acourbot@...dia.com>, John Hubbard
	<jhubbard@...dia.com>, Alistair Popple <apopple@...dia.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, "lossin@...nel.org"
	<lossin@...nel.org>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Danilo Krummrich <dakr@...nel.org>
Subject: Re: [PATCH 0/4] nova-core Improve pin initializer code



> On Dec 18, 2025, at 10:52 AM, Danilo Krummrich <dakr@...nel.org> wrote:
> 
> This is a minor series to improve some of the pin initializer code to:
> 
> 1. Reduce redundancy caused by Result<impl PinInit<T, Error>> return
> values with pin_init_scope().
> 
> 2. Relocate code that technically fits in the pin initializer into the
> initializer itself.
> 
> While, thanks to pin_init_scope(), it is also possible to keep it as is,
> moving appropriate code into the initializer has the advantage that it
> structures the dependencies of fields naturally.
> 
> For instance, intermediate data that is only needed for a single field goes
> into the initializer block of this field, making it obvious that it is not
> needed by anything else.
> 
> On the other hand, intermediate data that is needed for multiple fields to
> initialize remains above the initializer, naturally indicating that it is
> needed my multiple fields.
> 
> Danilo Krummrich (4):
>  gpu: nova-core: fw: get rid of redundant Result in GspFirmware::new()
>  gpu: nova-core: fw: move appropriate code into pin initializer
>  gpu: nova-core: gsp: get rid of redundant Result in Gsp::new()
>  gpu: nova-core: gsp: move appropriate code into pin initializer

Reviewed-by: Joel Fernandes <joelagnelf@...dia.com>

thanks,

 - Joel


> 
> drivers/gpu/nova-core/firmware/gsp.rs | 134 +++++++++++++-------------
> drivers/gpu/nova-core/gpu.rs          |   2 +-
> drivers/gpu/nova-core/gsp.rs          |  73 +++++++-------
> drivers/gpu/nova-core/gsp/boot.rs     |   5 +-
> 4 files changed, 106 insertions(+), 108 deletions(-)
> 
> 
> base-commit: 97cf6bc0abd381fd84e5d8e978322a62a58fb00e
> --
> 2.52.0
>