linux-kernel - Re: [PATCH bpf-next v4 8/8] resolve_btfids: Change in-place update with raw binary output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzZA4czi1KEOrW9tn8v18LZN4FAqzrHyB_78VatEZhb+Fw@mail.gmail.com>
Date: Thu, 18 Dec 2025 13:15:00 -0800
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: Ihor Solodrai <ihor.solodrai@...ux.dev>
Cc: Alan Maguire <alan.maguire@...cle.com>, Alexei Starovoitov <ast@...nel.org>, 
	Andrea Righi <arighi@...dia.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Andrii Nakryiko <andrii@...nel.org>, Bill Wendling <morbo@...gle.com>, Changwoo Min <changwoo@...lia.com>, 
	Daniel Borkmann <daniel@...earbox.net>, David Vernet <void@...ifault.com>, 
	Donglin Peng <dolinux.peng@...il.com>, Eduard Zingerman <eddyz87@...il.com>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, John Fastabend <john.fastabend@...il.com>, 
	Jonathan Corbet <corbet@....net>, Justin Stitt <justinstitt@...gle.com>, KP Singh <kpsingh@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>, Nicolas Schier <nsc@...nel.org>, 
	Shuah Khan <shuah@...nel.org>, Song Liu <song@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, 
	Tejun Heo <tj@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, bpf@...r.kernel.org, 
	dwarves@...r.kernel.org, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org, sched-ext@...ts.linux.dev
Subject: Re: [PATCH bpf-next v4 8/8] resolve_btfids: Change in-place update
 with raw binary output

On Thu, Dec 18, 2025 at 9:54 AM Ihor Solodrai <ihor.solodrai@...ux.dev> wrote:
>
> On 12/17/25 4:33 PM, Ihor Solodrai wrote:
> > [...]
> > diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf
> > index 840a55de42da..b8569d450ed9 100644
> > --- a/scripts/Makefile.btf
> > +++ b/scripts/Makefile.btf
> > @@ -1,5 +1,10 @@
> >  # SPDX-License-Identifier: GPL-2.0
> >
> > +gen-btf-y                            =
> > +gen-btf-$(CONFIG_DEBUG_INFO_BTF)     = $(srctree)/scripts/gen-btf.sh
> > +
> > +export GEN_BTF := $(gen-btf-y)
> > +
>
> Ugh... GEN_BTF is not used anywhere in v4.
> Looks like I forgot a `git add` at some point.
>
> I'll wait a bit before sending a v5, in case there is more feedback.

It all looks good to me, so don't wait for any more feedback from my
side. If Eduard doesn't find anything in patch #8, please send new
revision, thanks!

>
> >  pahole-ver := $(CONFIG_PAHOLE_VERSION)
> >  pahole-flags-y :=
> >
> > @@ -18,13 +23,15 @@ pahole-flags-$(call test-ge, $(pahole-ver), 126)  = -j$(JOBS) --btf_features=enc
> >
> >  pahole-flags-$(call test-ge, $(pahole-ver), 130) += --btf_features=attributes
> >
> > -ifneq ($(KBUILD_EXTMOD),)
> > -module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base
> > -endif
> > -
> >  endif
> >
> >  [...]
>